dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > ahmadsamir wrote in kconfig_compiler.cpp:646 > Yep; (and who knows if Qt docs were as expansive/exhaustive as they're now > :)). > > And then fileNameOnly() became unneeded when QFileInfo was used in the code. I do, and they were, that was always a big selling point for Qt ;) (I started contributing to KDE at the time of Qt 1.1, in 1998) REPOSITORY R237 KConfig BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26177 To: ahmadsamir, #frameworks, dfaure, ervin, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
