pino added inline comments. INLINE COMMENTS
> kpropertiesdialog.cpp:1453 > + // Open the current folder in filelight > + KRun::run(QStringLiteral("/usr/bin/filelight"), { properties->url() }, > properties->window(), QStringLiteral("Filelight"), > QStringLiteral("filelight")); > +} please do not hardcode the path to filelight... other than breaking on systems where filelight is installed in a prefix different than /usr, this breaks on Mac and Windows (and not only). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns