fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kio_sftp.cpp:1480
> + if (!attr) {
> + sftp_attributes_free(attr);
> + int errorCode = toKIOError(sftp_get_error(mSftp));
This entire block is duplicated - can that be improved?
> kio_sftp.cpp:1492
> + } else {
> + sftp_attributes_free(attr);
> + int errorCode = toKIOError(sftp_get_error(mSftp));
AFAICT, this has to be done in every case.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D26191
To: feverfew, sitter, dfaure, fvogt
Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice,
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp,
mikesomov
