ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  This also has similarities with D26126 <https://phabricator.kde.org/D26126>, 
has the same defects and missed opportunities for sharing.
  
  Beside I'm not sure what we're trying to achieve here, those parts of 
kconfig_compiler are not that bad. I'm not a huge fan of series of "else if" 
but that's not really making kconfig_compiler hard to understand, the overall 
lack of consistent domain model and the way the code is generated on the other 
hand...

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26128

To: tcanabrava, ervin
Cc: ervin, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to