ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  In D26133#581832 <https://phabricator.kde.org/D26133#581832>, @tcanabrava 
wrote:
  
  > Because not all apps that use KConfigXT use a KCM, and I don't want to make
  >  it necessary to do so. This particular change is done with Kirogi in mind
  >  (that does not uses a KCM, and it's a pure QtQuick / Kirigami app, but uses
  >  KConfigXT)
  >  I'll add the testcase.
  
  
  Still this is the wrong layer of abstraction for that. KCM would need to 
adapt to the platform to autosave or not, if you're not using KCM then your own 
GUI need to adapt to the platform instead. By having this controlled by 
kconfig_compiler, the application gets no chance to adapt to the platform since 
it'll always be autosave as soon as you use the setting, whatever the platform.
  
  It needs to be solved higher up in the stack: KCM type of facilities. As you 
can tell, I'm very much against that change. ;-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26133

To: tcanabrava, ervin
Cc: ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Reply via email to