apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > ahmadsamir wrote in docbookl10nhelper.cpp:184 > I did it that way to indicate match is going to be re-assigned-to later on, > but it does look off a bit. :) The way of saying it will be re-defined is by not making it const ;). REPOSITORY R238 KDocTools BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26156 To: ahmadsamir, #documentation, ltoscano, apol Cc: apol, kde-doc-english, kde-frameworks-devel, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
