bruns added inline comments. INLINE COMMENTS
> timelinetools.cpp:119 > + QRegularExpressionMatch match; > + if ((match = s_dateRegexp.match(sections.last())).hasMatch()) { > dateString = sections.last(); Pleae avoid assigning in an `if (...)` expression, just move it to the previous line. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams