bruns added a comment.

  I think the Summary is very poor.
  
  You only give a phenomenological reason (it no longer crashes), but thats 
insufficient. State what happens without the change (i.e. who owns what), and 
why doing it differently is **always** correct.
  
  Giving a good summary makes reviewing much easier, and also helps any later 
contributors.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26117

To: anthonyfieroni, broulik, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to