bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > main.cpp:44 > KAboutData aboutData(QStringLiteral("baloo"), i18n("Baloo File > Extractor"), QLatin1String(PROJECT_VERSION)); > - aboutData.addAuthor(i18n("Vishesh Handa"), i18n("Maintainer"), > QStringLiteral("vha...@kde.org"), QStringLiteral("http://vhanda.in")); > + aboutData.addAuthor(i18n("Vishesh Handa"), i18n("Maintainer"), > QStringLiteral("vha...@kde.org"), QStringLiteral("https://vhanda.in")); > Just drop this line completely, Vishesh has not been involved with Baloo for years ... > main.cpp:47 > KAboutData aboutData(QStringLiteral("baloo"), i18n("Baloo File Indexing > Daemon"), PROJECT_VERSION); > - aboutData.addAuthor(i18n("Vishesh Handa"), i18n("Maintainer"), > QStringLiteral("vha...@kde.org"), QStringLiteral("http://vhanda.in")); > + aboutData.addAuthor(i18n("Vishesh Handa"), i18n("Maintainer"), > QStringLiteral("vha...@kde.org"), QStringLiteral("https://vhanda.in")); > dito REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26089 To: jhayes, ngraham, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams