ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, mardelle. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY In staleMatchesManaged() using toLocalFile() means that it'll fail for remote files, e.g. fish://u...@example.com/home/remote/test.txt . Use path() instead. This fixes kautosavefiletest. Note that running that unit test gives: KAutoSaveFileTest::test_locking() org.kde.kcoreaddons: Could not lock file: "/home/ahmad/.local/share/stalefiles/qttest/test.txtEQofish_%2Fhome%2FremotexOzeiEQo" But the same happens when building from commit 88d1909 <https://phabricator.kde.org/R244:88d190934b92dc815eb530bc5f493292b4fe400d>, so it's not related to the recent changes AFAICS. TEST PLAN The code compiles and the unit tests pass. REPOSITORY R244 KCoreAddons BRANCH l-tolocalfile-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D25980 AFFECTED FILES src/lib/io/kautosavefile.cpp To: ahmadsamir, #frameworks, mpyne, dfaure, mardelle Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
