dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > thumbnail.cpp:730 > > + KFileItem item(fileUrl); > + For local files, QFileInfo would be more straightforward, no? You'd just use lastModified() on line 735 and size() on line 736. KFileItem is mostly meant to encapsulate kioslave listDir/stat results. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
