leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS
> apol wrote in engine.cpp:744 > Shouldn't we make sure rootPath ends with /? > at least with an ASSERT if we know it's there. Hmm... It /should/ be done, but it's also not a bad thing to perform a touch of sanitising on this, so... yup, let's just do that, update incoming REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25824 To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns