dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > khistorycombobox.cpp:415 > > +#if KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66) > void KHistoryComboBox::setPixmapProvider(KPixmapProvider *provider) s/ENABLE/BUILD/ in .cpp files > khistorycombobox.cpp:499 > > +#if KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66) > KPixmapProvider *KHistoryComboBox::pixmapProvider() const BUILD > khistorycombobox.h:195 > + * Sets an icon provider, so that items in the combobox can have an icon. > + * The provider is a function that takes a QString and returns a QIcon > + */ Missing `@since 5.66` REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
