dfaure created this revision.
dfaure added reviewers: broulik, mart, vkrause, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
The old traders could lookup both applications and plugins, but plugins
should nowadays be loaded via their JSON file, no desktop-file trader
needed anymore.
To get rid of plugins and servicetypes from the API, and keep
only the application-lookup-related code, the older traders will be
deprecated and their users should either switch to JSON for plugins
(KPluginLoader)
or KApplicationTrader for application desktop files.
One API question remains:
KApplicationTrader::self()->query("...") like the old traders, or
KApplicationTrader::query("...") (static methods only, or making it a
namespace, a bit procedural rather than OO), or
KApplicationTrader().query("...") like QMimeDatabase/QFontDatabase (but with
default ctors for performance) ?
TEST PLAN
New unittest (partly based on kservicetest, but simplified and added new
types of checks) passes
REPOSITORY
R309 KService
BRANCH
kapplicationtrader
REVISION DETAIL
https://phabricator.kde.org/D25698
AFFECTED FILES
autotests/CMakeLists.txt
autotests/kapplicationtradertest.cpp
autotests/kservicetest.cpp
autotests/kservicetest.h
src/CMakeLists.txt
src/services/kapplicationtrader.cpp
src/services/kapplicationtrader.h
src/services/kservicetypetrader.h
src/sycoca/ksycocaentry.h
To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
