mart added inline comments.

INLINE COMMENTS

> plasma.h:285
> +        ImmutableBackground = 8, /** The user shouldn't have the possibility 
> to  */
>          DefaultBackground = StandardBackground /**< Default settings: both 
> standard background */
>      };

DefaultBackground should be StandardBackground|ImmutableBackground
in order to have this feature only for applets that explicitly support this 
(some applets just look silly or kinda broken due to the limited use of 
ColorScope around, so this shouldn't be supported unless the applet explicitly 
says so)

strictly speaking should be bc, as existing binaries shouldn't fail with it 
(tough just believe the default is a different one which can give problems as 
before the user code was checking for hints === something rather than 
hints&something

So probably this flag based approach isn't much usable and different api may be 
needed?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25590

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to