kossebau added a comment.
Two more nitpicks while this has my attention (sadly no time/idea to comment
on the general usefulness) :)
INLINE COMMENTS
> kcolumnheadersmodel.h:57
> + void setSourceModel(QAbstractItemModel *newSourceModel);
> + Q_SIGNAL void sourceModelChanged();
> +
For consistency I would prefer having a full Q_SIGNALS section:
Q_SIGNALS:
void sourceModelChanged();
That matches the usual pattern and helps when reading raw headers to learn
about API of classes.
> kcolumnheadersmodel.h:60
> +private:
> + const std::unique_ptr<KColumnHeadersModelPrivate> d;
> +};
Why not QScopedPointer (for consistency in KF code)? Is that one going to be
deprecated in favour of std::unique_ptr?
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D25311
To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,
michaelh, ngraham, bruns
