cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
I like the overall effect, but I don't like the new static registry. We already have some registry in KateGlobal for all views, we would just need to allow to access the KateModeMenuList for the individual view then we can use that global list of views to touch all of them. That would be preferable to have an other global hashing. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25390 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
