cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Looks good in principle.
  
  Could we not at least remove
  
  install( FILES kregexpeditor/kregexpeditor.desktop DESTINATION 
${KDE_INSTALL_KSERVICETYPES5DIR} )
  
  too?
  We need to keep the header to have the application compiling, but the desktop 
file can go away now, or?
  
  Beside that, should the header not get a deprecation attribute to ensure 
nobody new picks that up?

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25538

To: nicolasfella, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to