kossebau added a comment.
Looks good, besides nitpicks :) INLINE COMMENTS > krecursivefilterproxymodel.cpp:22 > > +#if KITEMMODELS_ENABLE_DEPRECATED_SINCE(5, 65) > #include <QMetaMethod> This should be KITEMMODELS_BUILD_DEPRECATED_SINCE (BUILD., not ENABLE) > krecursivefilterproxymodel.h:28 > > #include "kitemmodels_export.h" > Being a duplicate now, this include can be removed. > krecursivefilterproxymodel.h:93 > > + @deprecated since 5.65, use > QSortFilterProxyModel::setRecursiveFilteringEnabled(true) instead. > */ Perhaps refer to above related comments as well. > krecursivefilterproxymodel.h:102 > */ > + KITEMMODELS_DEPRECATED_VERSION(5, 65, "Use > QSortFilterProxyModel::setRecursiveFilteringEnabled(true)") > explicit KRecursiveFilterProxyModel(QObject *parent = nullptr); More helpful would be perhaps "Use QSortFilterProxyModel directly and QSortFilterProxyModel::setRecursiveFilteringEnabled(true)" REPOSITORY R275 KItemModels BRANCH deprecate (branched from master) REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, ngraham, bruns, kpiwowarski, asturmlechner, cfeck, cullmann, vkrause, cordlandwehr, knauss, dfaure
