kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land.
Seems fine by pure patch reading. INLINE COMMENTS > konqbookmarkmenu.h:51 > * @param collec parent collection for the KActions. > */ > + KBOOKMARKS_DEPRECATED_VERSION(5, 65, "This class has moved to Konqueror") Should also be noted in the API dox with a @since, for good example purpose. Actually best to be done in the class API dox, though KonqBookmarkMenu does not have one yet (and thus also not picked up by kapidox/ecm_add_qch doxygen usage). So would just add to both constructors' API dox. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D25489 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
