bruns added a comment.
In D23787#541963 <https://phabricator.kde.org/D23787#541963>, @poboiko wrote: > > and another example which: > > > > - is currently skipped though it should be indexed > > - is indexed after this change > > There shouldn't be any. I mean, "PlaintextExtractor" should be inside `exList` for anything that starts with `text/`... Then whats the "Secondly ..." paragraph in the summary about? INLINE COMMENTS > davidedmundson wrote in app.cpp:173 > This original line seemed very very wrong. > > Just because we won't want to index phase 2 isn't a reason to remove the > filename indexing - it'll just keep running phase 1 on itself again and again. > > So +1 on that Off by one error - phase one is content indexing already, phase zero is filename/filestat. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23787 To: poboiko, #baloo, bruns, ngraham Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
