ahmadsamir added inline comments. INLINE COMMENTS
> vkrause wrote in jobuidelegate.cpp:365 > sslMetaData is a QMap<QString, ...>, ie. value() has no QLatin1String > overload, calling it with a QLatin1String will work but convert to a QString > at runtime (involving a memory allocation), using QStringLiteral avoids that. Right, value() is what matters here, thanks for explaining. > vkrause wrote in ksslinfodialog.cpp:263 > In theory, yes. However, changing this here and now would trigger quite some > ripple effect through the code, which currently is using QList everywhere, so > I'd suggest to do that as a separate change (if at all), to not hide > security-relevant changes under lots of QList -> QVector porting noise. The > other thing to consider the consistency in this code if we change just a > single use from QList to QVector, especially if that's not a > performance-sensitive path and Qt6 is supposed to change all this anyway > (QList's implementation going away). OK, thanks for explaining. (But I think there still should be a "// static" comment for that method). REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolasfella Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
