Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem?
Just speculating, if an app opens as multiple and then another instance tries to open as unique, it should reuse the existing one or merge? I did not try to change the registered name as actually nothing happens when a second instance of an unique app opens, it silently closes - so in a way I did not registered an unique application as name - pid, I just passed the arguments to the currently opened ::multiple application, and quit. On Sun, 3 Nov 2019 at 15:07 David Faure <nore...@phabricator.kde.org> wrote: > dfaure added a comment. View Revision <https://phabricator.kde.org/D25084> > > If I read the patch correctly, then running a multi-instance app ( > konsole-1234) and then running it as unique will lead to konsole-1234 > instead of the expected konsole. > Worse, if there was a completely unrelated konsolesettings application > running, then konsole would try to register as konsolesettings instead of > konsole. > In other words, at least this should be startsWith(d->serviceName + '-'), > right? > > *REPOSITORY* > R271 KDBusAddons > > *REVISION DETAIL* > https://phabricator.kde.org/D25084 > > *To: *tcanabrava, adridg, dfaure > *Cc: *dfaure, GB_2, davidedmundson, adridg, ngraham, > kde-frameworks-devel, LeGast00n, michaelh, bruns >
