kossebau added a comment.

  As said, I do not think this would be "better" code. And it's violating a bit 
the goal of zero cost abstractions, given this adds runtime need which could be 
avoided compared to the old code.
  When using the I18N_NOOP, one has to know what you do and when you later on 
pass data pointers instead of literals to i18n calls. Thinking people who do 
that are in general challenged to ensure the proper context call is still used 
might be challenged in other places before IMHO.
  
  And no, I do not want to do hacks in my own code, that proposal will be 
ignored. Let's have KI18n provide a nice API for developers, and not get in 
their way in some halfhearted way to be foolproof.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Reply via email to