dfaure added a comment.

  Any reason why you didn't implement my suggestion of
  
     DeleteJobIOWorker *ioworker() {
         if (!m_ioworker) {
               ...
         }
         return m_ioworker;
     }
    [...] 
    QMetaObject::invokeMethod(ioworker(), "rmfile", [...]);
  
  ?
  A call to an initSomething() method can easily be forgotten, while an 
on-demand getter ensure that the worker is created when it's needed (for the 
first time).
  Sorry for the nitpicking :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to