vonreth requested changes to this revision.
vonreth added a subscriber: dfaure.
vonreth added a comment.
This revision now requires changes to proceed.


  Rest looks good to me.
  @dfaure you created the initial version what do you think?

INLINE COMMENTS

> kicontheme.cpp:79
> +    for (const auto &iconDir : 
> QStandardPaths::locateAll(QStandardPaths::AppDataLocation, 
> QStringLiteral("icons"), QStandardPaths::LocateDirectory)) {
> +        QDirIterator it(iconDir, QStringList() << QLatin1String("*.rcc"), 
> QDir::Files);
> +        while (it.hasNext()) {

I guess we can use an Initializer here

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24989

To: cullmann, #frameworks, vonreth
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to