meven added a comment.
In D24962#554586 <https://phabricator.kde.org/D24962#554586>, @dfaure wrote: > I like the approach. Thanks for the suggestion in the last diff. I feared the callback hell, but this was not too difficult in fact. > Just a few minor things. > > (and remember to remove the WIP from the commit log and the phab request) Great review, thanks. > The passing of iterators to another thread *looks* scary, but of course it's safe here since we only run one subjob at a time, so the list can't change while the worker does its work. I have update the code to instead pass the bool isLink and use `removeFirst`. It should be more efficient than begin == it + erase. I feel the code looks simpler, although you need to understand the looping spreading over 4 functions. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
