ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
It doesn't compile:
/home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:1389:72: error:
‘QString::QString(const char*)’ is private within this context
1389 | KRun::runCommand(QStringLiteral("filelight"), directory,
nullptr, QStringLiteral("/"));
|
^
Anyway, should use `KRun::runApplication()` for this since that's made for
launching GUI apps and handling arguments passed to the binary.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
