ahmadsamir added a comment.

  Is cipherDigestMethod() (method @ line 96) needed? the cipher name is 
inserted in sslMetaData a couple of lines after that.
  
  Using some test code:
  QList<QSslCipher> list = QSslConfiguration::supportedCiphers();
  for (QSslCipher c  : list) {
  
    qInfo() << c.name();
  
  }
  
  I get:
  "TLS_AES_256_GCM_SHA384"
  "TLS_CHACHA20_POLY1305_SHA256"
  "TLS_AES_128_GCM_SHA256"
  "ECDHE-ECDSA-AES256-GCM-SHA384"
  "ECDHE-RSA-AES256-GCM-SHA384"
  "DHE-RSA-AES256-GCM-SHA384"
  "ECDHE-ECDSA-CHACHA20-POLY1305"
  "ECDHE-RSA-CHACHA20-POLY1305"
  "DHE-RSA-CHACHA20-POLY1305"
  "ECDHE-ECDSA-AES128-GCM-SHA256"
  "ECDHE-RSA-AES128-GCM-SHA256"
  "DHE-RSA-AES128-GCM-SHA256"
  "ECDHE-ECDSA-AES256-SHA384"
  "ECDHE-RSA-AES256-SHA384"
  "DHE-RSA-AES256-SHA256"
  "ECDHE-ECDSA-AES128-SHA256"
  "ECDHE-RSA-AES128-SHA256"
  "DHE-RSA-AES128-SHA256"
  "ECDHE-ECDSA-AES256-SHA"
  "ECDHE-RSA-AES256-SHA"
  "DHE-RSA-AES256-SHA"
  "ECDHE-ECDSA-AES128-SHA"
  "ECDHE-RSA-AES128-SHA"
  "DHE-RSA-AES128-SHA"
  "RSA-PSK-AES256-GCM-SHA384"
  "DHE-PSK-AES256-GCM-SHA384"
  "RSA-PSK-CHACHA20-POLY1305"
  "DHE-PSK-CHACHA20-POLY1305"
  "ECDHE-PSK-CHACHA20-POLY1305"
  "AES256-GCM-SHA384"
  "PSK-AES256-GCM-SHA384"
  "PSK-CHACHA20-POLY1305"
  "RSA-PSK-AES128-GCM-SHA256"
  "DHE-PSK-AES128-GCM-SHA256"
  "AES128-GCM-SHA256"
  "PSK-AES128-GCM-SHA256"
  "AES256-SHA256"
  "AES128-SHA256"
  "ECDHE-PSK-AES256-CBC-SHA384"
  "ECDHE-PSK-AES256-CBC-SHA"
  "SRP-RSA-AES-256-CBC-SHA"
  "SRP-AES-256-CBC-SHA"
  "RSA-PSK-AES256-CBC-SHA384"
  "DHE-PSK-AES256-CBC-SHA384"
  "RSA-PSK-AES256-CBC-SHA"
  "DHE-PSK-AES256-CBC-SHA"
  "AES256-SHA"
  "PSK-AES256-CBC-SHA384"
  "PSK-AES256-CBC-SHA"
  "ECDHE-PSK-AES128-CBC-SHA256"
  "ECDHE-PSK-AES128-CBC-SHA"
  "SRP-RSA-AES-128-CBC-SHA"
  "SRP-AES-128-CBC-SHA"
  "RSA-PSK-AES128-CBC-SHA256"
  "DHE-PSK-AES128-CBC-SHA256"
  "RSA-PSK-AES128-CBC-SHA"
  "DHE-PSK-AES128-CBC-SHA"
  "AES128-SHA"
  "PSK-AES128-CBC-SHA256"
  "PSK-AES128-CBC-SHA"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to