anthonyfieroni added inline comments. INLINE COMMENTS
> kmaterka wrote in kstatusnotifieritem.cpp:790 > This check is not reliable, assosiatedWidget can change. Anyway, this doesn't > matter here. > Did you read whole comment? Probably KSNI should not own the menu but it is > doing that for 10 (more?) years. It is even documented in the API. > Your idea will not fix the main issue, we can't set a parent to menu in > KDEPlatformSystemTrayIcon. Main purpose of this hack is to prevent deletion > of menu when it is *not* possible to set parent. `Probably KSNI should not own the menu` Yes, widget that creates the menu should, like in bug report example. Make the changes here, then we should find a way to parent the menu, which is the right approach. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24755 To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
