dfaure added inline comments. INLINE COMMENTS
> global.cpp:99 > > -#ifndef KIOCORE_NO_DEPRECATED > KIOCORE_EXPORT QTime KIO::calculateRemaining(KIO::filesize_t totalSize, > KIO::filesize_t processedSize, KIO::filesize_t speed) Isn't some ifdef still needed for this deprecated method? > global.h:105 > * @return calculated remaining time > + * @deprecated Since 3.4, use calculateRemainingSeconds() instead, as QTime > is limited to 23:59:59 > */ LOL 3.4 was long ago ;) good find :) > kfileitem.cpp:1242 > > -#ifndef KIOCORE_NO_DEPRECATED > bool KFileItem::acceptsDrops() const I'm confused, isn't this what *_BUILD_DEPRECATED_SINCE is for? [repeats] REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
