ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> resultset.h:78
> +        QString resource() const;             ///< String representation of 
> resource (can represent an url or a path)
> +        QUrl url() const;                     ///< Url representation of a 
> resource based on internal resource, readonly, @since 5.64
>          QString title() const;                ///< Title of the resource, or 
> URL if title is not known

`url` or `resourceUrl`?

I hoped we are not going to have these problems after the death of Nepomuk. 
Thought file paths for files and urls for everything else would be a sane 
default. :)

Also, can you add a `TODO: KF6 rething the function names` for these two.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24741

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to