broulik added a comment.

  Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so 
it gets assigned a window.

INLINE COMMENTS

> keysequencehelper.cpp:118
>      QString shortcutDisplay;
> -
> +    QQuickItem* keySequenceItem;
>      //! Check the key sequence against KStandardShortcut::find()

Typically store items created by QtQuick in a `QPointer` so we can detect when 
they are garbage collected

> keysequencehelper.h:65
> +        READ keySequenceItem
> +        WRITE setKeySequenceItem)
>  

this needs a `NOTIFY` argument, corresponding `signal` and `emit` in the setter

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to