dfaure added inline comments. INLINE COMMENTS
> kactioncollection.h:278 > */ > + KXMLGUI_DEPRECATED_VERSION(5, 0, "Do not rely on") > QT_MOC_COMPAT void removed(QAction *action); Does this work? It's a signal. Won't this only warn at emit time? (while QT_MOC_COMPAT is what leads to a warning at connect time) Asking because you didn't do this in D24465 <https://phabricator.kde.org/D24465> for the windowChanged() signals, so something seems inconsistent. > kactioncollection.h:314 > + KXMLGUI_DEPRECATED_VERSION(5, 0, "Use > KActionCollection::slotActionHovered()") > QT_MOC_COMPAT virtual void slotActionHighlighted(); > +#endif (pre-existing) QT_MOC_COMPAT for a slot? Any idea what this might do? REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
