mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land.
The change looks good and builds in various combinations of CMake options (after I installed the changeset from D23789 <https://phabricator.kde.org/D23789>). I encountered that excluding deprecated components from the build requires a version of x.y.z. (not just x.y) but other than that things were straightforward from a developer's perspective. Once D23789 <https://phabricator.kde.org/D23789> is in we can commit to kcoreaddons. REPOSITORY R244 KCoreAddons BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D23800 To: kossebau, #frameworks, mpyne Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
