dfaure updated this revision to Diff 66991. dfaure marked 4 inline comments as done. dfaure added a comment.
Make changes suggested by Friedrich's code review (thanks!) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24160?vs=66665&id=66991 BRANCH 2019_09_modernize_range_for REVISION DETAIL https://phabricator.kde.org/D24160 AFFECTED FILES src/core/authinfo.cpp src/core/desktopexecparser.cpp src/core/kcoredirlister.cpp src/core/kioglobal_p.cpp src/core/kmountpoint.cpp src/core/kprotocolmanager.cpp src/core/krecentdocument.cpp src/core/ksambashare.cpp src/core/ksslcertificatemanager.cpp src/core/udsentry.cpp src/filewidgets/kdirsortfilterproxymodel.cpp src/ioslaves/help/kio_help.cpp src/ioslaves/http/http.cpp src/ioslaves/trash/kio_trash.cpp src/ioslaves/trash/tests/testtrash.cpp src/ioslaves/trash/trashimpl.cpp src/kcms/kio/smbrodlg.cpp src/kntlm/kntlm.cpp src/kpac/proxyscout.cpp src/kssld/kssld.cpp src/widgets/kfileitemdelegate.cpp src/widgets/kopenwithdialog.cpp src/widgets/kpropertiesdialog.cpp src/widgets/krun.cpp src/widgets/kshellcompletion.cpp src/widgets/ksslinfodialog.cpp src/widgets/kurlcompletion.cpp src/widgets/kurlrequester.cpp src/widgets/previewjob.cpp To: dfaure, bruns, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns