dfaure created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY Reading code like service->path() is confusing, because it looks like the path to the .desktop file (which is in fact entryPath(), most likely because path() was already taken). The key in the desktop file is called Path (and that won't change), but in the C++ API, workingDirectory() is much clearer. TEST PLAN Builds REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D23939 AFFECTED FILES src/services/kservice.cpp src/services/kservice.h src/services/kservice_p.h To: dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns