aacid added a comment.

  +1 looks sane but i have **not** tried this

INLINE COMMENTS

> kcollapsiblegroupbox.cpp:288
>  {
> -    int top, left, right, bottom;
> -    getContentsMargins(&left, &top, &right, &bottom);
> +    QMargins margins = contentsMargins();
>  

if you get bored, add const?

> kpixmapregionselectordialog.cpp:53
>              //Set maximum size for picture
> -            QDesktopWidget desktopWidget;
> -            QRect screen = desktopWidget.availableGeometry();
> +            QRect screenGeometry = 
> pixmapSelectorWidget->screen()->availableGeometry();
>              pixmapSelectorWidget->setMaximumWidgetSize(

same, if you get bored, const

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to