jgrulich added a comment.
I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" groupbox, imo it should be separated groupbox INLINE COMMENTS > strongswanwidget.cpp:100 > d->ui.ipComp->setChecked(dataMap[NM_STRONGSWAN_IPCOMP] == "yes"); > + d->ui.proposal->setChecked(dataMap[NM_STRONGSWAN_PROPOSAL] == "yes"); > + d->ui.ike->setText(dataMap[NM_STRONGSWAN_IKE]); Same here, probably pointless to set "IKE" and "ESP" when "Enable custom proposals" is false. > pino wrote in strongswanwidget.cpp:155-156 > should these be set only when the custom proposals are accepted? Indeed, they should be set only when the "Enable custom proposals" checkbox is checked. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
