ngraham added a comment.
In D22069#523824 <https://phabricator.kde.org/D22069#523824>, @aacid wrote: > If what you're saying is that that you run ./bin/ki18n-klocalizedstringtest without those lines and the test fails for you, well you'll have to give me access to your machine since i can't fix what i can't debug (i.e. it works fine here) Yes that is exactly what I'm saying: ~/kde/src/ki18n$ (localized-long-number-strings) ../../build/ki18n/bin/ki18n-klocalizedstringtest ********* Start testing of KLocalizedStringTest ********* Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.1.0) PASS : KLocalizedStringTest::initTestCase() FAIL! : KLocalizedStringTest::correctSubs() Compared values are not the same Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" Expected (QString(" 4,20")) : " 4,20" Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)] PASS : KLocalizedStringTest::wrongSubs() PASS : KLocalizedStringTest::removeAcceleratorMarker() PASS : KLocalizedStringTest::miscMethods() SKIP : KLocalizedStringTest::translateToFrenchLowlevel() French test files not usable. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(466)] SKIP : KLocalizedStringTest::translateToFrench() French test files not usable. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(479)] PASS : KLocalizedStringTest::translateQt() SKIP : KLocalizedStringTest::addCustomDomainPath() French test files not usable. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(536)] SKIP : KLocalizedStringTest::testThreads() French test files not usable. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(479)] FAIL! : KLocalizedStringTest::testThreads() Compared values are not the same Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" Expected (QString(" 4,20")) : " 4,20" Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)] FAIL! : KLocalizedStringTest::testThreads() Compared values are not the same Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" Expected (QString(" 4,20")) : " 4,20" Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)] FAIL! : KLocalizedStringTest::testThreads() Compared values are not the same Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" Expected (QString(" 4,20")) : " 4,20" Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(221)] SKIP : KLocalizedStringTest::testLocalizedTranslator() French test files not usable. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(511)] QWARN : KLocalizedStringTest::semanticTags() "Tag 'numid' is not defined in message {<__kuit_internal_top__>Connecting to <numid>22</numid>...</__kuit_internal_top__...}." XFAIL : KLocalizedStringTest::semanticTags() what happened to <numid/>? TODO. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(351)] PASS : KLocalizedStringTest::semanticTags() SKIP : KLocalizedStringTest::multipleLanguages() French or Catalan test files not usable. Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(550)] PASS : KLocalizedStringTest::cleanupTestCase() Totals: 7 passed, 4 failed, 6 skipped, 0 blacklisted, 20ms ********* Finished testing of KLocalizedStringTest ********* Unfortunately I won't be able to make it to Akademy next week so I'm not sure when will be the next time for us to share a room. If the code with your proposed removal looks good to you and you're confident that thee issue is a local mis-configuration on my side, can I land the patch? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns
