zzag added inline comments.

INLINE COMMENTS

> zzag wrote in outputdevice.cpp:391
> That's not safe if the raw string is dynamically allocated, use qstrlen 
> instead.

Correction: that's not reliable way to check whether a C string is empty. You 
assume that all empty strings have the same address, which in some cases cannot 
be true, e.g. if the string is dynamically allocated.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to