leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS
> ahiemstra wrote in atticaprovider.cpp:355 > Fair enough. I do try to make sure to use vectors as much as possible in new > API, but consistency is also a good argument. :) Think i might just pop in a TODO KF6 comment... just sort of make sure that even if it ends up not being a wholesale policy, we do it here :) > ahiemstra wrote in Dialog.qml:76 > It would match with the FileDialog API > (https://doc.qt.io/qt-5/qml-qtquick-dialogs-filedialog.html#fileUrls-prop) > however, which also has this behaviour. My main problem with signal > parameters is that you cannot bind to them, so using the result gets trickier. Hmm, so it would. I guess documentation helps anyway, i'll switch to doing it like that :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
