jbbgameich added inline comments.

INLINE COMMENTS

> peopleqmlplugin.cpp:64
>      qmlRegisterUncreatableType<ActionTypeWrapper>(uri, 1, 0, "ActionType", 
> QStringLiteral("You cannot create ActionType"));
> +    qmlRegisterSingletonType<DeclarativeKPeopleManager>(uri, 1, 0, 
> "Manager", [] (QQmlEngine*, QJSEngine*) -> QObject* { return new 
> DeclarativeKPeopleManager; });
>  }

Not sure whether this should follow the Person(s) naming scheme as well..

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22968

To: apol, #frameworks, jbbgameich, bshah
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to