nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision.
REVISION SUMMARY The functions isBold(), isItalic(), etc. return the resulting format between the combination of the Theme and the XML highlighting file. This one works very well. The problem is that if the Theme is empty, it isn't possible to correctly apply these attributes, especially the turn off of these. These new functions let you know if the attributes bold, italic, underline, strikeout, color, backgroundColor, selColor & selBackgroundColor are specifically set in the XML files. For example, if `Format::definitionHasBold()` is **true**, the `Format::isBold(...)` function returns the value of the `bold` attribute set in the XML file. If `Format::definitionHasBold()` is **false**, the `bold` attribute isn't in the XML file and `Format::isBold(...)` returns the value defined by the Theme. REPOSITORY R216 Syntax Highlighting BRANCH format-new-functions REVISION DETAIL https://phabricator.kde.org/D23515 AFFECTED FILES src/lib/format.cpp src/lib/format.h To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
