apol added a comment.
In D23470#519726 <https://phabricator.kde.org/D23470#519726>, @kossebau wrote: > How exactly are you using ths from KService? If just by passing the flag set, won't this break any existing custom properties which are relying on "," as separator? diff --git a/src/services/kservice.cpp b/src/services/kservice.cpp index f89c1f1..7d85153 100644 --- a/src/services/kservice.cpp +++ b/src/services/kservice.cpp @@ -560,7 +560,7 @@ QVariant KServicePrivate::property(const QString &_name, QVariant::Type t) const // All others // For instance properties defined as StringList, like MimeTypes. // XXX This API is accessible only through a friend declaration. - return KConfigGroup::convertToQVariant(_name.toUtf8().constData(), it->toString().toUtf8(), t); + return KConfigGroup::convertToQVariant(_name.toUtf8().constData(), it->toString().toUtf8(), t, true); > `grep "Type=QStringList" /usr/share/kservicetypes5/ -r` hints there are quite some properties which no longer would be properly parsed then for existing desktop files? Yes, there's a lot of misconstructed desktop files in KDE due to this bug (and similar, I presume). Hence the e-mail I sent. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23470 To: apol, #frameworks Cc: pino, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
