kossebau created this revision. kossebau added reviewers: Plasma, hein, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision.
REVISION SUMMARY get_fields() already cares for removing the quotes, the bits in get_str() are thus already operating on the final string, as well as it is broken in the calculation of the text length to copy. Possibly were left-over from initial code drafts, as all this logic was already in the initial commit to kdelibs in e5b75f8409e7 <https://phabricator.kde.org/R446:e5b75f8409e7fee6c798fac21a8a0e03be771b07> TEST PLAN Startup notification still works as before, quoted values like Description="Launching Dolphin" are still read in as before REPOSITORY R278 KWindowSystem BRANCH dropdeadcodeforremovingquotesfromstartupdatavalue REVISION DETAIL https://phabricator.kde.org/D23418 AFFECTED FILES src/kstartupinfo.cpp To: kossebau, #plasma, hein, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
