dfaure marked 3 inline comments as done. dfaure added inline comments. INLINE COMMENTS
> zzag wrote in kwindowsystem.cpp:490 > Each time this method is called a new foreign QWindow object will be created. > Can you please explain why leaking those objects is okay? Ah I didn't realize that QWindow::fromWinId was allocating a QWindow [IMHO it should have been called createFromWinId, then], but indeed it's logical. Fixed. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23108 To: dfaure, broulik, davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
