ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed.
Another tiny change, and I think it is ready to land. Unless someone else sees other issues. INLINE COMMENTS > GtkEventSpy.cpp:126 > + > + if (exec.at(0) == QStringLiteral("'") && exec.at(exec.size() - 1) == > QStringLiteral("'")) { > + // remove "'" caracters wrapping the command No need to compare chars with strings: if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'') REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart