chinmoyr added inline comments. INLINE COMMENTS
> sitter wrote in AuthBackend.h:61 > I didn't check super carefully but at a glance the backend api is not public > API so we could probably refactor this right now already. > > Also, shouldn't the callerID be a const ref? the mac backend modifies `callerID` later on so I think it was deliberately kept here. > sitter wrote in kauthaction.h:246 > Should the old functions maybe be marked deprecated? I deprecated it. Except the unit tests this isn't used anywhere in the backend. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter Cc: ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, michaelh, bruns
