feverfew created this revision. feverfew added reviewers: dfaure, fvogt, chinmoyr, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision.
REVISION SUMMARY This patch does the following: 1. Makes sure the close() signal is actually emitted when close() is called. 2. Documents the FileJob functions more accurately, and ensures the file slave acts similarly to the two other slaves that implement these functions (smb/sftp). 3. Fixes an issue when purposefully reading 0 bytes. TEST PLAN The application I am developing on that depends on FileJob now successfully receives the close() signal when required and does not experience the bug mentioned when reading 0 bytes. Existing read/write/seek functionality is not broken. Tests also pass. REPOSITORY R241 KIO BRANCH ConsistentRead (branched from master) REVISION DETAIL https://phabricator.kde.org/D23194 AFFECTED FILES src/core/filejob.cpp src/core/filejob.h src/core/slavebase.cpp src/core/slavebase.h src/core/slaveinterface.cpp src/core/slaveinterface.h src/ioslaves/file/file.cpp src/ioslaves/file/file.h To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
